improvement(data-drains): docs page, screenshots, and search/UI polish#4547
improvement(data-drains): docs page, screenshots, and search/UI polish#4547waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Polishes the Data Drains settings screen. Adds a client-side search box that filters drains by name/source/destination/cadence, introduces clearer row expand affordance (chevron), tweaks empty/error states and scrolling layout, and refreshes the create-drain modal styling (including destination icon support) and skeleton loading layout. Reviewed by Cursor Bugbot for commit efa1e7d. Configure here. |
Greptile SummaryThis PR adds two screenshots to the enterprise data-drains docs page and polishes the settings UI: a search bar over the drains table, a
Confidence Score: 4/5Safe to merge after restoring suppressHydrationWarning on the two locale-formatted date cells. Removing suppressHydrationWarning from cells that call new Date(...).toLocaleString() will produce React hydration mismatches in production whenever the server process locale differs from the browser locale. Both the lastRunAt cell in DrainRow and the startedAt span in RunRow are affected. Everything else in the PR is low-risk UI polish and static content. apps/sim/ee/data-drains/components/data-drains-settings.tsx — the two locale-formatted date render sites that lost their hydration suppression attribute. Important Files Changed
Reviews (2): Last reviewed commit: "improvement(data-drains): docs page, scr..." | Re-trigger Greptile |
dd93722 to
12bfb23
Compare
12bfb23 to
47979f8
Compare
47979f8 to
efa1e7d
Compare
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit efa1e7d. Configure here.
Adds the enterprise data-drains docs page with two screenshots, a search bar over the drains table, and a UI cleanup pass on the settings component (size-*, useMemo removal, text-sm fixes). The previously-proposed env-var reference feature has been dropped — drain credentials remain raw values, encrypted at rest by the existing pipeline.
efa1e7d to
9cbc701
Compare
Summary
Type of Change
Testing
Tested manually
Checklist