Skip to content

improvement(data-drains): docs page, screenshots, and search/UI polish#4547

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/data-drains-envvar
May 10, 2026
Merged

improvement(data-drains): docs page, screenshots, and search/UI polish#4547
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/data-drains-envvar

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

@waleedlatif1 waleedlatif1 commented May 10, 2026

Summary

  • Add enterprise data-drains docs page with two screenshots (settings list, new-drain modal)
  • Add a search bar over the drains table
  • UI cleanup on the settings page: size-* normalization, removed unnecessary useMemo, text-sm fixes
  • Dropped the previously-proposed env-var reference feature — credentials remain raw values, encrypted at rest by the existing pipeline. Centralized rotation can be revisited later as a focused feature.

Type of Change

  • Improvement / docs

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment May 10, 2026 8:45pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 10, 2026

PR Summary

Low Risk
Low risk: documentation and client-side UI refinements only, with no changes to drain APIs, auth, or export behavior.

Overview
Improves Data Drains documentation and UI ergonomics. The enterprise data-drains.mdx page now includes two setup screenshots.

Polishes the Data Drains settings screen. Adds a client-side search box that filters drains by name/source/destination/cadence, introduces clearer row expand affordance (chevron), tweaks empty/error states and scrolling layout, and refreshes the create-drain modal styling (including destination icon support) and skeleton loading layout.

Reviewed by Cursor Bugbot for commit efa1e7d. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 10, 2026

Greptile Summary

This PR adds two screenshots to the enterprise data-drains docs page and polishes the settings UI: a search bar over the drains table, a ChevronDown expand indicator per row, an S3 destination icon in the create modal, and various layout/size normalizations.

  • Docs: two screenshots (data-drains-list.png, data-drains-new.png) inserted into the Setup section with descriptive alt text.
  • Settings component: search bar filters drains by name, source, destination, and cadence; layout shifted to h-full flex-col for proper overflow scrolling; ModalTitle replaced by inline ModalHeader text; Cancel button variant normalized to default.
  • Skeleton: updated to mirror the new two-row header (callout placeholder + search/button bar) so the loading state matches the real layout.

Confidence Score: 4/5

Safe to merge after restoring suppressHydrationWarning on the two locale-formatted date cells.

Removing suppressHydrationWarning from cells that call new Date(...).toLocaleString() will produce React hydration mismatches in production whenever the server process locale differs from the browser locale. Both the lastRunAt cell in DrainRow and the startedAt span in RunRow are affected. Everything else in the PR is low-risk UI polish and static content.

apps/sim/ee/data-drains/components/data-drains-settings.tsx — the two locale-formatted date render sites that lost their hydration suppression attribute.

Important Files Changed

Filename Overview
apps/sim/ee/data-drains/components/data-drains-settings.tsx Adds search bar, ChevronDown expand indicator, S3 destination icon, and modal UI polish. Removing suppressHydrationWarning from locale-formatted date cells will cause hydration mismatches in production.
apps/sim/ee/data-drains/components/data-drains-skeleton.tsx Skeleton updated to mirror the new two-row header layout (callout + search/button bar). Straightforward and accurate.
apps/docs/content/docs/en/enterprise/data-drains.mdx Two screenshots added to the Setup section with descriptive alt text. No content issues.
apps/docs/public/static/enterprise/data-drains-list.png New binary screenshot asset for the drains list view.
apps/docs/public/static/enterprise/data-drains-new.png New binary screenshot asset for the new drain modal.

Reviews (2): Last reviewed commit: "improvement(data-drains): docs page, scr..." | Re-trigger Greptile

Comment thread apps/sim/app/api/organizations/[id]/data-drains/[drainId]/route.ts Outdated
Comment thread apps/sim/lib/api/contracts/data-drains.ts Outdated
Comment thread apps/sim/lib/api/contracts/data-drains.ts
Comment thread apps/sim/lib/data-drains/service.ts Outdated
@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/data-drains-envvar branch from dd93722 to 12bfb23 Compare May 10, 2026 20:25
@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/data-drains-envvar branch from 12bfb23 to 47979f8 Compare May 10, 2026 20:28
@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/data-drains-envvar branch from 47979f8 to efa1e7d Compare May 10, 2026 20:35
@waleedlatif1 waleedlatif1 changed the title feat(data-drains): support env var references and workspace scoping improvement(data-drains): docs page, screenshots, and search/UI polish May 10, 2026
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Comment thread apps/sim/ee/data-drains/components/data-drains-settings.tsx Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit efa1e7d. Configure here.

Adds the enterprise data-drains docs page with two screenshots, a
search bar over the drains table, and a UI cleanup pass on the
settings component (size-*, useMemo removal, text-sm fixes).

The previously-proposed env-var reference feature has been dropped —
drain credentials remain raw values, encrypted at rest by the
existing pipeline.
@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/data-drains-envvar branch from efa1e7d to 9cbc701 Compare May 10, 2026 20:42
@waleedlatif1 waleedlatif1 merged commit ae680af into staging May 10, 2026
8 of 9 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/data-drains-envvar branch May 10, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant