Skip to content

Remove outdated Node.js version guards from docstring tests #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 3 commits into from
May 11, 2026
+4 −43
Merged

Remove outdated Node.js version guards from docstring tests #8421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42a0862
Remove outdated Node.js version guards from docstring tests
aspeddro May 10, 2026
39f5c84
add coment and fix node version
aspeddro May 11, 2026
9501d59
add js file
aspeddro May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions tests/docstring_tests/DocTest.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,13 @@ let nodeVersion =

let ignoreRuntimeTests = [
(
// Ignore tests that require Node.js v20+
20,
["Stdlib_Array.toReversed", "Stdlib_Array.toSorted"],
),
(
// Ignore tests that require Node.js v22+
22,
[
"Stdlib_Promise.withResolvers",
"Stdlib_Set.union",
"Stdlib_Set.isSupersetOf",
"Stdlib_Set.isSubsetOf",
"Stdlib_Set.isDisjointFrom",
"Stdlib_Set.intersection",
"Stdlib_Set.symmetricDifference",
"Stdlib_Set.difference",
],
),
(
// Ignore tests that require Node.js v24+
// Ignore tests that require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/escape#browser_compatibility)
24,
["Stdlib_RegExp.escape"],
),
(
// Not available in Node.js yet
1000,
// Require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/setFloat16#browser_compatibility)
24,
["Stdlib_DataView.getFloat16", "Stdlib_DataView.setFloat16"],
),
]
Expand Down
22 changes: 1 addition & 21 deletions tests/docstring_tests/DocTest.res.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading