Remove outdated Node.js version guards from docstring tests#8421
Open
aspeddro wants to merge 1 commit intorescript-lang:masterfrom
Open
Remove outdated Node.js version guards from docstring tests#8421aspeddro wants to merge 1 commit intorescript-lang:masterfrom
aspeddro wants to merge 1 commit intorescript-lang:masterfrom
Conversation
Node.js 20 has been dropped and the minimum is now v22, so the version guards for Node.js 20+ and 22+ features are no longer needed.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 20 has been dropped and the minimum is now v22, so the version guards for Node.js 20+ and 22+ features are no longer needed.