test: relax test-memory-usage arrayBuffers check#63220
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: relax test-memory-usage arrayBuffers check#63220inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63220 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224950
Branches 42530 42530
==========================================
- Hits 202548 202536 -12
+ Misses 14188 14183 -5
- Partials 8214 8231 +17 🚀 New features to boost your workflow:
|
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
3800dad to
4d4a78c
Compare
Contributor
Contributor
Author
|
Could someone rerun the failed macOS jobs? The failures look unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous GC-before-baseline approach did not make the exact
arrayBuffersdelta stable in CI.Refs: #63214 (comment)
process.memoryUsage().arrayBuffersis process-wide, so unrelated ArrayBuffer/Buffer backing stores may be freed between snapshots. This keeps the test checking that the live 10 MiBArrayBufferis included, without requiring an exact process-wide delta.Fixes: #63210