Skip to content

test: relax test-memory-usage arrayBuffers check#63220

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:relax-test-memory-usage-arraybuffers-check
Open

test: relax test-memory-usage arrayBuffers check#63220
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:relax-test-memory-usage-arraybuffers-check

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented May 10, 2026

The previous GC-before-baseline approach did not make the exact arrayBuffers delta stable in CI.
Refs: #63214 (comment)

process.memoryUsage().arrayBuffers is process-wide, so unrelated ArrayBuffer/Buffer backing stores may be freed between snapshots. This keeps the test checking that the live 10 MiB ArrayBuffer is included, without requiring an exact process-wide delta.

Fixes: #63210

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 10, 2026
@inoway46 inoway46 marked this pull request as ready for review May 10, 2026 04:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (facd71e) to head (4d4a78c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63220      +/-   ##
==========================================
- Coverage   90.04%   90.03%   -0.01%     
==========================================
  Files         713      713              
  Lines      224950   224950              
  Branches    42530    42530              
==========================================
- Hits       202548   202536      -12     
+ Misses      14188    14183       -5     
- Partials     8214     8231      +17     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@inoway46 inoway46 force-pushed the relax-test-memory-usage-arraybuffers-check branch from 3800dad to 4d4a78c Compare May 10, 2026 06:46
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73315/

@inoway46
Copy link
Copy Markdown
Contributor Author

inoway46 commented May 10, 2026

Could someone rerun the failed macOS jobs? The failures look unrelated to this PR.
https://github.com/nodejs/node/actions/runs/25622148862/job/75210643491?pr=63220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-memory-usage failing on Windows

3 participants