test: reduce flakiness of different-registry-per-thread#63209
Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
Open
test: reduce flakiness of different-registry-per-thread#63209aduh95 wants to merge 2 commits intonodejs:mainfrom
different-registry-per-thread#63209aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
There was an assumption that the `WeakRef` would be kept alive but it seems to not always be true on Windows. This commit makes sure it's kept alive. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
unflaky-test-process-finalization
branch
from
ed9990d to
fc9c902
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63209 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224950
Branches 42532 42534 +2
==========================================
- Hits 202542 202539 -3
- Misses 14175 14185 +10
+ Partials 8233 8226 -7 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
aduh95
force-pushed
the
unflaky-test-process-finalization
branch
from
96323a2 to
1a9791e
Compare
Collaborator
ShogunPanda
approved these changes
May 10, 2026
H4ad
approved these changes
May 10, 2026
RafaelGSS
approved these changes
May 10, 2026
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
panva
approved these changes
May 10, 2026
ljharb
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an assumption that the
WeakRefwould be kept alive but it seems to not always be true on Windows. This commit makes sure it's kept alive.Refs: #63057 (comment)
Fixes: #63056