refactor: bring in types from zarr-metadata#3961
Open
d-v-b wants to merge 5 commits into
Open
Conversation
github-actions
Bot
added
the
needs release notes
Contributor
Author
|
cc @chuckwondo |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
- Coverage 93.27% 93.27% -0.01%
==========================================
Files 87 87
Lines 11739 11726 -13
==========================================
- Hits 10950 10937 -13
Misses 789 789
🚀 New features to boost your workflow:
|
ilan-gold
reviewed
May 11, 2026
| 'google-crc32c>=1.5', | ||
| 'typing_extensions>=4.13', | ||
| 'donfig>=0.8', | ||
| 'zarr-metadata>=0.1.1', |
Contributor
There was a problem hiding this comment.
So development of these packages will proceed entirely independently and one is not developed against another? Or is there a secrete setting somewhere that enables this to be linked?
Contributor
Author
There was a problem hiding this comment.
can you explain what you mean? zarr-metadata is on pypi, which is how we expect people who install zarr-python to get that package. zarr-metadata will be developed with the goal of primarily supporting zarr-python, and when new versions of zarr-metadata are released, we would update zarr-python to depend on them.
…into use-zarr-metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces some of our types with exports from zarr-metadata. I expect a few related PRs, alternating between ones like this (importing types) and ones that add missing types to zarr-metadata.
TODO:
docs/user-guide/*.mdchanges/