fix: rolldown, GraphQL PR lookup, non-fatal errors#348
Open
fix: rolldown, GraphQL PR lookup, non-fatal errors#348
Conversation
- Replace rollup + 3 plugins with rolldown for simpler bundling - Switch from flaky REST `/commits/:sha/pulls` to GraphQL `associatedPullRequests` for PR association (the REST endpoint intermittently returns 500s or empty arrays for squash-merge commits) - Make `verifyCommitReview` errors non-fatal: warn + notify Slack channel (without @channel) instead of failing the action - Add CI run URL to error messages for easier debugging - Log the `gh api graphql` command for manual repro from CI logs - Add `noEmit` to tsconfig (rolldown handles output, not tsc/tsgo) - Use `@typescript/native-preview` (tsgo) for type checking Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rollup/plugin-commonjs,@rollup/plugin-node-resolve,@rollup/plugin-typescript,tslib) with rolldown for simpler bundling. AddednoEmitto tsconfig since rolldown handles output.verifyCommitReviewfrom the flaky RESTGET /commits/:sha/pulls+listReviews(N+1) to a single GraphQL query usingassociatedPullRequests. The REST endpoint intermittently returns HTTP 500s or empty arrays for squash-merge commits.verifyCommitReviewerrors no longer fail the action viacore.setFailed. Instead, they log acore.warningand send a quiet Slack notification (no@channel) with the error and a link to the CI run.typescriptto@typescript/native-previewfor type checking.Test plan
yarn packageproduces a singledist/index.jsbundleyarn tsgopasses with no errorsgh api graphqlcommand logged in CI output is copy-pasteable🤖 Generated with Claude Code