Fix building with new rust-nightly.#561
Draft
jarovo wants to merge 2 commits intorust-osdev:mainfrom
Draft
Conversation
Member
|
jarovo
force-pushed
the
main
branch
2 times, most recently
from
c74d791 to
951729a
Compare
Compiling wiht newest nightly failed this way:
error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
--> /home/jhenner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.37.26/src/backend/linux_raw/io/errno.rs:28:25
|
28 | #[cfg_attr(rustc_attrs, rustc_layout_scalar_valid_range_start(0xf001))]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after bumping the tempfile to use new deps, there was this linker issue to be fixed:
To address this I made disk_buffer a stack variable instead of static variable because the now large
.textregion pushed the.bssso much that it didn't fit to the 16bit address range ( the.textprecedes the.bssin thestage-2-link.ldfile). Another advantage is that this allowed me to remove the unsafe block. I think I was getting some memory corruption when dealing with the references to the static mem region.IIRC After moving the
disk_bufferto the stack the some of the testsBIOS bootand then nothing was happening. After changing the ESP to0x00080000all the tests are passing. Only thelarge_ramdisktest sometimes fails. It seems to be flaky - many times it passes.