Added pyphen#15645
Merged
JelleZijlstra merged 5 commits intopython:mainfrom May 10, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
| cut: int | ||
|
|
||
| def __init__(self, pattern: str, alternative: str) -> None: ... | ||
| def __call__(self, value: str) -> int: ... |
Member
There was a problem hiding this comment.
Suggested change
| def __call__(self, value: str) -> int: ... | |
| def __call__(self, value: str | int) -> int: ... |
Or even SupportsInt.
| def __call__(self, value: str) -> int: ... | ||
|
|
||
| class DataInt(int): | ||
| def __new__(cls, value: int, data: Any = ..., reference: DataInt | None = ...) -> Self: ... |
Member
There was a problem hiding this comment.
Missing the data attribute (which can be at least DataInt or None, possibly more types).
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
- pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
Contributor
Author
|
@JelleZijlstra thanks for the change I was going to address that but couldn't find time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authors are oposed Kozea/Pyphen#81 (comment) to adding type hints directly