Skip to content

add db cleanup for PyPy #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattip wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −18
Open

add db cleanup for PyPy #472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc18f9
add db cleanup for PyPy
mattip May 10, 2026
dedaa04
do session resetting differently, from review
mattip May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions pyperformance/data-files/benchmarks/bm_sqlalchemy_declarative/run_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ class Address(Base):
# session.commit(). If you're not happy about the changes, you can
# revert all of them back to the last commit by calling
# session.rollback()
session = DBSession()


# add 'npeople' people to the database
Expand All @@ -59,29 +58,30 @@ def bench_sqlalchemy(loops, npeople):
total_dt = 0.0

for loops in range(loops):
with DBSession() as session:
Copy link
Copy Markdown

@zzzeek zzzeek May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. does it work / fix the problem? this "with" syntax for the session was introduced probably long after this test suite was written

Copy link
Copy Markdown
Contributor Author

@mattip mattip May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the warning/crash.

# drop rows created by the previous benchmark
session.query(Person).delete(synchronize_session=False)
session.query(Address).delete(synchronize_session=False)
session.query(Person).delete(synchronize_session=False)
session.query(Address).delete(synchronize_session=False)

# Run the benchmark once
t0 = pyperf.perf_counter()
# Run the benchmark once
t0 = pyperf.perf_counter()

for i in range(npeople):
# Insert a Person in the person table
new_person = Person(name="name %i" % i)
session.add(new_person)
session.commit()
for i in range(npeople):
# Insert a Person in the person table
new_person = Person(name="name %i" % i)
session.add(new_person)
session.commit()

# Insert an Address in the address table
new_address = Address(post_code='%05i' % i, person=new_person)
session.add(new_address)
session.commit()
# Insert an Address in the address table
new_address = Address(post_code='%05i' % i, person=new_person)
session.add(new_address)
session.commit()

# do 100 queries per insert
for i in range(npeople):
session.query(Person).all()
# do 100 queries per insert
for i in range(npeople):
session.query(Person).all()

total_dt += (pyperf.perf_counter() - t0)
total_dt += (pyperf.perf_counter() - t0)

return total_dt

Expand Down
Loading