gh-149630: Fix pylifecycle multiple init/fini cleanup bugs #149631
Open
Wulian233 wants to merge 1 commit intopython:mainfrom
Open
gh-149630: Fix pylifecycle multiple init/fini cleanup bugs #149631Wulian233 wants to merge 1 commit intopython:mainfrom
Wulian233 wants to merge 1 commit intopython:mainfrom
Conversation
Fix multiple resource-management and error-path bugs in the interpreter lifecycle.
Release the builtins module reference on builtin initialization failures and keep it owned until default import initialization succeeds, avoiding an extra NULL assignment. Also DECREF results from non-dict sys.modules clear calls, route subinterpreter initialization failures through cleanup after thread-state detach, release __main__ setup references on PyDict_SetItemString failures, and check stdin/stdout sys object setup failures consistently with stderr.
Tests run:
- ./configure --with-pydebug
- git diff --check
- make -j2 Python/pylifecycle.o
- make -j2 python Programs/_testembed
- make -j2
- Programs/_testembed test_repeated_init_and_subinterpreters
- ./python - <<'PY'
import _interpreters
interp = _interpreters.create()
_interpreters.destroy(interp)
print('ok')
PY
- make patchcheck (fails because this checkout has no upstream remote matching https://github.com/python/cpython)
Wulian233
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
- This looks user-facing, so let's add a news entry. You don't have to be specific; just something like "Fix some memory leaks upon interpreter initialization failing."
- It's hard to write tests for things like this, but I'd appreciate something small that stresses one of these code paths. (I'm less concerned about the memory leaks in this regard -- I just want to make sure we have something testing the error path.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we add skip news?
https://gist.github.com/devdanzin/b022ff2d1304a4b2b8d3d8750abd8da5