gh-126850: Handle multiple functions with same name in StatsProfile#149618
Open
ejthomas wants to merge 4 commits intopython:mainfrom
Open
gh-126850: Handle multiple functions with same name in StatsProfile#149618ejthomas wants to merge 4 commits intopython:mainfrom
ejthomas wants to merge 4 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new attribute
func_profile_by_locto theStatsProfileclass inpstats.pythat provides access to the function profiles keyed by a tuple of filename, linenumber and function name (rather than just function name as used infunc_profiles), so that profiling data for multiple functions with the same name can be accessed via theStatsProfiledata structure.A new test is added to highlight the new behaviour in
test_pstats.py.A new attribute is used instead of changing the existing behavior for backwards compatibility (though I'm aware this is very similar to the existing attribute, I think this edge case not handled in
func_profilesis relatively common when profiling more complex code where certain common names likerun()orbuild()are likely to appear multiple times).I considered making the key a more formal data structure with named attributes like a frozen dataclass or namedtuple, but when looking at the surrounding code, it looked like a simple tuple was a good fit. I gave it an alias to clarify intent, but I'd be very happy to use an alternative approach if that would improve readability further.