Broaden receive data buffer types#1315
Open
Harshal96 wants to merge 1 commit intopython-hyper:masterfrom
Open
Conversation
Harshal96
force-pushed
the
feat/strict-bytes-buffer-types
branch
from
0eae096 to
46d91d5
Compare
Harshal96
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
H2Connection.receive_dataandFrameBuffer.add_dataannotations frombytesto a local PEP 688-styleBufferprotocol.memoryviewso byte-like inputs are handled consistently.bytearrayandmemoryview, and run it in the lint tox environment.Fixes #1305.
Validation
Local CI-equivalent checks run before advancing this draft:
uv run --no-project --with tox --with tox-gh-actions tox -e py311uv run --no-project --with tox --with tox-gh-actions tox -e lintuv run --no-project --with tox --with tox-gh-actions tox -e py310,py312,py313,py314,packaginguv run --python 3.13 --no-project --with tox --with tox-gh-actions tox -r -e docsUpstream GitHub Actions note: the PR's
CIworkflow is currentlyaction_requiredwith no jobs, so it has not executed on GitHub yet. The remainingh2specjob is Linux-specific in the workflow because it downloads a Linux h2spec binary, so I could not reproduce that exact job on this macOS workspace.