Fix: add localized fallback for p5.sound reference landing page#1362
Open
mikhailbond1 wants to merge 1 commit intoprocessing:mainfrom
Open
Fix: add localized fallback for p5.sound reference landing page#1362mikhailbond1 wants to merge 1 commit intoprocessing:mainfrom
mikhailbond1 wants to merge 1 commit intoprocessing:mainfrom
Conversation
Collaborator
|
Hi @mikhailbond1 Thank you for this PR. I tested this locally on both main and 2.0. The fix works correctly on main. I noticed the same 404 existed on the 2.0 branch so I cherry-picked your commit and opened a separate PR for it here: #1394 |
Author
|
Sounds good! Thanks for checking it out and opening the separate PR for 2.0 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1346
Changes:
Adds a localized fallback route for the p5.sound reference landing page. Previously, /reference/p5.sound/ only existed for English. Visiting /es/reference/p5.sound/, /hi/reference/p5.sound/, /ko/reference/p5.sound/, or /zh-Hans/reference/p5.sound/ would result in a 404.
This PR adds src/pages/[locale]/reference/p5.sound.astro which generates the landing page for all non-default locales using getCollectionInLocaleWithFallbacks, falling back to English content where translations don't exist.
PR Checklist:
npm run lintpassesnpm run testpassesnpm run build&npm run previewpass