fix(testing): return [] instead of None from get_logs for non-Chrome browsers#3779
Open
troclaux wants to merge 1 commit intoplotly:devfrom
Open
fix(testing): return [] instead of None from get_logs for non-Chrome browsers#3779troclaux wants to merge 1 commit intoplotly:devfrom
troclaux wants to merge 1 commit intoplotly:devfrom
Conversation
troclaux
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
…browsers When running tests with non-Chrome drivers, get_logs() returned None, causing assertions like `assert dash_duo.get_logs() == []` to fail. Returning an empty list is consistent with the Chrome path, which also returns an empty list when there are no logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser.get_logs()returnsNonewhen the driver is not Chrome. This breaks test assertions likeassert dash_duo.get_logs() == []on Firefox/Safari.The Chrome path already returns
[](an empty list comprehension) when there are no log entries, so returning[]on other drivers is the consistent behaviour. The warning message is updated to reflect the change.Changes
dash/testing/browser.py: changedreturn None→return []and updated the warning text accordingly.Test plan
dash_duo.get_logs() == []will no longer raise aTypeErroron non-Chrome drivers