Allow main asymmetric visibility to be omitted#3
Open
rhydb wants to merge 1 commit into
Open
Conversation
Author
|
I noticed that existing tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places to check for these tokens were missed in c6c5c98, which meant that the main visibility could not be omitted. This PR adds them to the list of modifiers, and to the allowed start tokens of member declarations and parameters.
As the test outputs show, they are added to the
setVisibilityTokenfor parameters, and tomodifiersfor everything else. They have not been added to the explicit modifiers for traits, enums, or interface members. If the main visibility is omitted, it isn't added to the output - is this ok?I have not tested the LSP, but this should hopefully fix phpactor/phpactor#2959 as the tokens are now picked up.