Drop articles before domain nouns for rename safety#56
Merged
Conversation
Apply the substrate rename-safety contract: remove "a" / "an" / "the" directly preceding Shop, Shopkeeper, and ItemTag (in any case form) across test descriptors, code comments, OpenAPI summaries, and substrate meta-docs. The agent's text-only rename pipeline would otherwise produce article disagreements like "an patient" or "a office" when users pick consonant- or vowel-starting rename targets. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a/an/thedirectly precedingShop,Shopkeeper, andItemTag(any case form) so the agent's text-only rename pipeline can't produce article disagreements like "an patient" or "a office" when users pick consonant- or vowel-starting rename targets..yaml), and substrate meta-docs.docs/andtest/.Changes
test/controllers/api/v1/shopkeeper/{item_tags,shops}_controller_test.rb,test/models/shop_test.rbtest/controllers/api/v1/shopkeeper/base_controller_test.rb,test/models/accounts_invitation_test.rbdocs/openapi.yamldocs/phase1-rails-api.md,docs/nativeapptemplate-substrate-v2-overview.mdTest plan
bin/rubocop— 227 files inspected, no offensesbin/rails test— 398 runs, 815 assertions, 0 failures, 0 errors, 0 skipsItemTag → Patient(consonant) substitution and confirm no "an patient" / "an Patient" leaks remain🤖 Generated with Claude Code