Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
May 8, 2026
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
When an
ion-alerthas two buttons whose combined text is too long to fit on one row, flex-wrap pushes the second button onto a new row. The horizontal layout's right border (drawn between buttons viaalert.ios.scss) stays on the first button, leaving a stray vertical separator at the wrap edge. Thealert-button-group-verticalclass only triggers onbuttons.length > 2, so two-button alerts can't opt into the clean vertical layout even when they visually need it.What is the new behavior?
The alert now watches its button group with a
ResizeObserverand togglesalert-button-group-verticalwhenever the buttons render at differentoffsetTopvalues, so wrapping two-button alerts get the same vertical treatment as three-or-more-button alerts. The wrap state resets when thebuttonsprop changes so a new button set is re-evaluated from scratch, and the observer is re-attached inconnectedCallbackso reconnected alerts keep working. The layout read is deferred viarafto avoid forcing synchronous layout and to sidestepResizeObserverloop warnings.Does this introduce a breaking change?
Other information
The right-border styling between buttons only exists in iOS mode, so the new e2e test is iOS only
Preview:
A lot of the updated screenshots are because of the new alert button. We should probably make note of these to go back and update the tests so they focus on the modal and don't include the background to prevent this sort of update spam in the future.