fix: improve thread-safe and atomic writing#204
Open
vazarkevych wants to merge 6 commits intogrowthbook:mainfrom
Open
fix: improve thread-safe and atomic writing#204vazarkevych wants to merge 6 commits intogrowthbook:mainfrom
vazarkevych wants to merge 6 commits intogrowthbook:mainfrom
Conversation
…riments and callbacks in GrowthBook, move fireSubscriptions to Util class
… ConcurrentHashMap and CopyOnWriteArrayList for assigned experiments and callbacks in GrowthBook, move fireSubscriptions to Util class
… and InMemoryStickyBucketServiceImpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses thread-safety issues across several core components of the GrowthBook Java SDK.
Changes
GBFeaturesRepositoryAtomicBoolean,AtomicLong,AtomicReferencewhere appropriateArrayListfor refresh callbacks toCopyOnWriteArrayListrefreshStrategyandsseRequestasvolatilesseHttpClientandsseEventSourceplain fields withAtomicReferenceFileCachingManagerImplFiles.move(ATOMIC_MOVE)pattern to prevent partial reads during concurrent accesssaveContentandloadCachewith class-level synchronizationGrowthBookHashMapwithConcurrentHashMapfor assigned experiments mapArrayListwithCopyOnWriteArrayListfor callbackscallbacksandevaluationContextasvolatileGrowthBookClientrepositoryfield asvolatileinitialize()withsynchronizedblock to prevent double-initializationHashMap/ArrayListwithConcurrentHashMap/CopyOnWriteArrayListglobalContextasvolatileGrowthBookUtilsfireSubscriptionsfrom bothGrowthBookandGrowthBookClientinto a shared utility method to eliminate duplicationInMemoryStickyBucketServiceImplNativeJavaGbFeatureRepositoryGbCacheManagerinitialization order