Fix flaky strRemovePrefix property test asserting wrong invariant#290
Draft
Fix flaky strRemovePrefix property test asserting wrong invariant#290
Conversation
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flaky property-based test in string_ops.test.ts with control characters
Fix flaky strRemovePrefix property test asserting wrong invariant
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
The property at
tests/stats/string_ops.test.ts:356asserted an invariant thatstrRemovePrefixdoes not satisfy.strRemovePrefixmirrors Python'sstr.removeprefix()and strips at most one leading occurrence, but the test claimed the result must never start withprefixwhenstrdid:Any input where the prefix repeats at the start (e.g.
str = "aa", prefix = "a") is a legitimate counterexample. The reported["",""]counterexample was two control characters (file separator,\x1c) that render as empty in the console — control characters were a red herring; the underlying invariant was simply wrong. Flakiness depended on whether shrinking happened to land on such inputs for a given seed.How did you fix it?
Replaced the property with the actual contract of
str.removeprefix(): when the prefix is present, exactly one leading occurrence is stripped; otherwise the string is returned unchanged.The implementation in
src/stats/string_ops.tswas already correct and is unchanged.Testing
Ran
bun test tests/stats/string_ops.test.tsrepeatedly; all 54 tests pass deterministically.