Merged
Conversation
Adds comprehensive tests for the parseHTTPResult function in internal/mcp/http_transport.go. The function had no direct test coverage despite being used in the HTTP transport request path. Tests cover: - Happy path: 200 OK with valid JSON-RPC result - Error path: 200 OK with invalid/empty JSON body - Non-200 status codes (400, 401, 500): verify synthetic JSON-RPC error is generated with correct code (-32603) and status message - SSE-formatted 200 response is correctly parsed - JSON-RPC error in 200 response is passed through unchanged Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds direct unit test coverage for internal/mcp.parseHTTPResult, the HTTP transport helper responsible for turning raw HTTP responses into JSON-RPC Response values.
Changes:
- Added
TestParseHTTPResultwith subtests covering 200 OK parsing, invalid/empty bodies, non-200 status handling, SSE-formatted responses, and pass-through of JSON-RPCerrorfields. - Extends existing
internal/mcp/http_transport_test.gotest suite with a new section dedicated toparseHTTPResult.
Show a summary per file
| File | Description |
|---|---|
| internal/mcp/http_transport_test.go | Adds a new parseHTTPResult test section with multiple subtests to cover key parsing and error-handling scenarios. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+1328
to
+1332
| func TestParseHTTPResult(t *testing.T) { | ||
| t.Run("status 200 with valid JSON-RPC result", func(t *testing.T) { | ||
| result := &httpRequestResult{ | ||
| StatusCode: http.StatusOK, | ||
| ResponseBody: []byte(`{"jsonrpc":"2.0","id":1,"result":{"value":"hello"}}`), |
Collaborator
|
@copilot address review feedback |
Contributor
Updated the PR description to remove the incorrect CI note. The reviewer was right — the CI workflow uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Coverage Improvement:
parseHTTPResultFunction Analyzed
internal/mcpparseHTTPResultinternal/mcp/http_transport.goparseJSONRPCResponseWithSSEWhy This Function?
parseHTTPResultis the core result-parsing step in the HTTP transport's request pipeline — every call viasendHTTPRequestroutes through it. Despite being called in production, the function had zero direct test coverage. It contains meaningful branches around HTTP error handling and JSON-RPC error synthesis that benefit from explicit tests.Tests Added
-32603and HTTP status textCoverage Report
Test Execution
Generated by Test Coverage Improver
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.