feat: add AbstractCommand::callSilently()#10177
Open
paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
Open
feat: add AbstractCommand::callSilently()#10177paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
AbstractCommand::callSilently()#10177paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
Conversation
5 tasks
michalsn
reviewed
May 10, 2026
Comment on lines
+515
to
+530
| protected function callSilently(string $command, array $arguments = [], array $options = [], ?bool $noInteractionOverride = true): int | ||
| { | ||
| $priorIo = CLI::getInputOutput(); | ||
|
|
||
| CLI::setInputOutput(new NullInputOutput()); | ||
|
|
||
| try { | ||
| return $this->call($command, $arguments, $options, $noInteractionOverride); | ||
| } finally { | ||
| if ($priorIo instanceof InputOutput) { | ||
| CLI::setInputOutput($priorIo); | ||
| } else { | ||
| CLI::resetInputOutput(); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This makes me wonder... should we also restore the CLI::$lastWrite state? Or this isn't really important? Honestly, I can't decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from michalsn's review on #10174.
Adds
AbstractCommand::callSilently($command, $arguments, $options, $noInteractionOverride = true)to invoke another modern command with its output discarded, so the parent can emit its own consolidated message.Two small supporting pieces:
CodeIgniter\CLI\NullInputOutput— anInputOutputsink that discards writes and returns an empty string frominput().CLI::getInputOutput()(@internal) — getter symmetric to the existingsetInputOutput()/resetInputOutput()pair.Checklist: