Backport darwin (amd64/arm64) kubectl-volsync support to release-0.15#2003
Backport darwin (amd64/arm64) kubectl-volsync support to release-0.15#2003qjoly wants to merge 1 commit intobackube:mainfrom
Conversation
|
Hi @qjoly. Thanks for your PR. I'm waiting for a backube member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Update kubectl-volsync/volsync.yaml to include darwin platform entries and fix linux URIs to use per-arch filenames matching the release workflow. sha256 values are placeholders updated at build time by make krew-plugin-manifest. Signed-off-by: Quentin Joly <quentinj@une-pause-cafe.fr>
98ce18b to
cd811c3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qjoly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
We're actually working on trying to get a pre-release of v0.16.0 out now, to test the actual darwin kubectl binary workflow, which has failed a couple times - I don't think we have any plans of doing a .z v0.15 release. |



Summary
This PR backports darwin support for the
kubectl-volsynckrew plugin to therelease-0.15branch.The same changes were merged to
mainvia PR #1933 and PR #2001, but they landed 4 hours after thev0.15.0release was published, leaving darwin users unable to install the plugin.Changes
.github/workflows/release.yml: addsGOOS: [linux, darwin]to the matrix, creating 4 build jobs (linux+darwin × amd64+arm64); darwin builds usemake krew-plugin-manifestto produce the tarball; upload step uses per-platform filenames (kubectl-volsync-$GOOS-$ARCH.tar.gz).krew.yaml: addsdarwin/amd64anddarwin/arm64platform entries using{{addURIAndSha}}sokrew-release-botcomputes the correct sha256 for each tarballkubectl-volsync/volsync.yaml: adds darwin platform entries and fixes linux URIs to the per-arch filename format, allowingmake test-krewto work on macOSTesting
On the next patch release (
v0.15.x), the CI will produce:kubectl-volsync-linux-amd64.tar.gzkubectl-volsync-linux-arm64.tar.gzkubectl-volsync-darwin-amd64.tar.gzkubectl-volsync-darwin-arm64.tar.gzkrew-release-botwill then open a PR tokrew-indexwith all four platforms.Fixes: darwin users getting
No platform available for darwin/arm64ordarwin/amd64when runningkubectl krew install volsync.