Skip to content

Backport darwin (amd64/arm64) kubectl-volsync support to release-0.15#2003

Open
qjoly wants to merge 1 commit intobackube:mainfrom
qjoly:feat/darwin-support
Open

Backport darwin (amd64/arm64) kubectl-volsync support to release-0.15#2003
qjoly wants to merge 1 commit intobackube:mainfrom
qjoly:feat/darwin-support

Conversation

@qjoly
Copy link
Copy Markdown

@qjoly qjoly commented May 7, 2026

Summary

This PR backports darwin support for the kubectl-volsync krew plugin to the release-0.15 branch.

The same changes were merged to main via PR #1933 and PR #2001, but they landed 4 hours after the v0.15.0 release was published, leaving darwin users unable to install the plugin.

Changes

  • .github/workflows/release.yml: adds GOOS: [linux, darwin] to the matrix, creating 4 build jobs (linux+darwin × amd64+arm64); darwin builds use make krew-plugin-manifest to produce the tarball; upload step uses per-platform filenames (kubectl-volsync-$GOOS-$ARCH.tar.gz)
  • .krew.yaml: adds darwin/amd64 and darwin/arm64 platform entries using {{addURIAndSha}} so krew-release-bot computes the correct sha256 for each tarball
  • kubectl-volsync/volsync.yaml: adds darwin platform entries and fixes linux URIs to the per-arch filename format, allowing make test-krew to work on macOS

Testing

On the next patch release (v0.15.x), the CI will produce:

  • kubectl-volsync-linux-amd64.tar.gz
  • kubectl-volsync-linux-arm64.tar.gz
  • kubectl-volsync-darwin-amd64.tar.gz
  • kubectl-volsync-darwin-arm64.tar.gz

krew-release-bot will then open a PR to krew-index with all four platforms.

Fixes: darwin users getting No platform available for darwin/arm64 or darwin/amd64 when running kubectl krew install volsync.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

Hi @qjoly. Thanks for your PR.

I'm waiting for a backube member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the size/M label May 7, 2026
@qjoly qjoly force-pushed the feat/darwin-support branch from 3fd0181 to 98ce18b Compare May 7, 2026 13:44
@qjoly qjoly changed the base branch from release-0.15 to main May 7, 2026 16:37
@openshift-ci openshift-ci Bot added size/L and removed size/M labels May 7, 2026
Update kubectl-volsync/volsync.yaml to include darwin platform entries
and fix linux URIs to use per-arch filenames matching the release workflow.
sha256 values are placeholders updated at build time by make krew-plugin-manifest.

Signed-off-by: Quentin Joly <quentinj@une-pause-cafe.fr>
@qjoly qjoly force-pushed the feat/darwin-support branch 2 times, most recently from 98ce18b to cd811c3 Compare May 7, 2026 16:38
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qjoly
Once this PR has been reviewed and has the lgtm label, please assign cooktheryan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added size/M and removed size/L labels May 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@tesshuflower
Copy link
Copy Markdown
Contributor

We're actually working on trying to get a pre-release of v0.16.0 out now, to test the actual darwin kubectl binary workflow, which has failed a couple times - I don't think we have any plans of doing a .z v0.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants