fix(lines): fix potential tooltip XSS vulnerability in lines series#21608
Merged
fix(lines): fix potential tooltip XSS vulnerability in lines series#21608
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential tooltip XSS injection vector in the lines series by ensuring line item names are rendered via the tooltip markup builder (which HTML-encodes content) rather than being returned as raw HTML.
Changes:
- Update
LinesSeriesModel.formatTooltipto always return anameValuetooltip markup block, using the itemnameor afromName > toNamefallback and correctly suppressing display when the value is missing/NaN. - Add a manual repro test page (
test/tooltip-xss.html) that attempts to inject an<img onerror=...>payload viadata.name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/chart/lines/LinesSeries.ts |
Routes line tooltip content through createTooltipMarkup('nameValue', ...) so names are HTML-encoded and values are handled consistently. |
test/tooltip-xss.html |
Adds a manual test case to verify tooltip rendering does not execute injected HTML/JS from line item names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
100pah
approved these changes
May 8, 2026
|
Thank you for the quick fix and review. Glad to help improve the security of Apache ECharts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix potential tooltip XSS vulnerability in lines series.
Comparison
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
See
test/tooltip-xss.htmlMerging options
Other information