refactor: derive Default on ConnectionParams and DatabaseSelection#174
Open
saurabh500 wants to merge 1 commit intoTabularisDB:mainfrom
Open
refactor: derive Default on ConnectionParams and DatabaseSelection#174saurabh500 wants to merge 1 commit intoTabularisDB:mainfrom
saurabh500 wants to merge 1 commit intoTabularisDB:mainfrom
Conversation
Add Default implementations so tests and driver-specific code can use
`..Default::default()` instead of spelling out every Option field.
- ConnectionParams: derive Default (all Option fields default to None,
driver defaults to empty String, database to Single(""))
- DatabaseSelection: manual Default impl → Single(String::new())
This is a precursor for TabularisDB#144 (SQL Server TLS/auth fields) — new
driver-specific fields won't require updating every existing test.
490/490 lib tests pass.
Contributor
Author
|
@debba the Default trait is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precursor for #144. Add
Defaultso tests can use..Default::default()as driver-specific fields land.ConnectionParams: derive DefaultDatabaseSelection: manual Default impl →Single(String::new())490/490 lib tests pass. Zero changes needed outside
models.rs.