Skip to content

fix(ios): restore IndexedRow wrapping in row detail pager#1184

Merged
datlechin merged 1 commit intomainfrom
fix/ios-row-detail-indexed-row-regression
May 10, 2026
Merged

fix(ios): restore IndexedRow wrapping in row detail pager#1184
datlechin merged 1 commit intomainfrom
fix/ios-row-detail-indexed-row-regression

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

The detail view model already guards row(at:) and cells(at:) against out-of-range indices, so this regression doesn't crash today the way the data browser one did. Restoring the wrapping puts identity-based diffing back in place and keeps the three iOS row lists on the same pattern.

Test plan

  • Build TableProMobile on the iOS scheme; SwiftLint passes (swiftlint lint --strict on touched files).
  • In the iOS app, open a row detail view, swipe the pager left/right, then trigger a list refresh that shrinks rows while the pager is mounted; confirm no Array._checkSubscript trap and that the pager re-anchors on the surviving rows.
  • Apply a filter on a PostgreSQL table on iOS (the build 11 repro from rcuni8@gmail.com) and confirm the data browser + row detail flow still works end to end.

@datlechin datlechin merged commit 47f18c1 into main May 10, 2026
3 checks passed
@datlechin datlechin deleted the fix/ios-row-detail-indexed-row-regression branch May 10, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant