fix(ios): restore IndexedRow wrapping in row detail pager#1184
Merged
fix(ios): restore IndexedRow wrapping in row detail pager#1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexedRow.wrap(...)wrapping inRowDetailView's pager that PR refactor(ios): extract row detail logic into RowDetailViewModel #1166 silently reverted while extractingRowDetailViewModel. TheForEach(viewModel.rows.indices, id: \.self)pattern is the same shape that caused the build 11 PostgreSQL filter crash (Array._checkSubscript, TestFlight feedbackAOsWBxPNuHp_NmN0QIclyc8) and that PR fix(ios): stop ForEach indices race in row lists and validate driver port range #1094 (f7ed420e) originally fixed.IndexedRowtoIndexedRow<Element>so the helper covers both flat[[String?]]rows (data browser, query editor) and the richer[Row]payload the row detail view model holds.The detail view model already guards
row(at:)andcells(at:)against out-of-range indices, so this regression doesn't crash today the way the data browser one did. Restoring the wrapping puts identity-based diffing back in place and keeps the three iOS row lists on the same pattern.Test plan
swiftlint lint --stricton touched files).rowswhile the pager is mounted; confirm noArray._checkSubscripttrap and that the pager re-anchors on the surviving rows.rcuni8@gmail.com) and confirm the data browser + row detail flow still works end to end.