fix(logs): show recent entries immediately on /logs#38
Merged
Conversation
|
@paulocarinhena is attempting to deploy a commit to the Projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/logsscreen connected successfully to the SSE endpoint (/api/logs/stream), but it often displayed no logs when opened.This happened because the watcher only emitted events when the log file size increased. So if logs already existed in the current file but no new lines were written at that moment, the UI stayed empty.
Root cause
In
setupLogWatcher()(server/index.js):start = Math.max(0, fileSize - 10000)) was computed,stat.size > fileSize).Fix implemented
processLogLineso SSE subscribers receive immediate history,Files changed
server/index.jsstartTailing(),stream.on('data')line splitting.Expected result
When opening
/logs, users now see recent existing entries from the active log file right away, instead of waiting for new log events to appear.