Support cross-origin authentication verification#759
Open
agektmr wants to merge 2 commits intoMasterKale:masterfrom
Open
Support cross-origin authentication verification#759agektmr wants to merge 2 commits intoMasterKale:masterfrom
agektmr wants to merge 2 commits intoMasterKale:masterfrom
Conversation
MasterKale
reviewed
May 9, 2026
| if (!expectedTopOrigin.includes(topOrigin)) { | ||
| const joinedExpectedTopOrigin = expectedTopOrigin.join(', '); | ||
| throw new Error( | ||
| `Unexpected cross-origin authentication within "${topOrigin}", expected one of: ${joinedExpectedTopOrigin}`, |
Owner
There was a problem hiding this comment.
A bit of a nitpick:
Suggested change
| `Unexpected cross-origin authentication within "${topOrigin}", expected one of: ${joinedExpectedTopOrigin}`, | |
| `Unexpected cross-origin authentication response origin "${topOrigin}", expected one of: ${joinedExpectedTopOrigin}`, |
| } else if (!expectedTopOrigin) { | ||
| // If `expectedTopOrigin` is not set, this is an unexpected cross-origin request. | ||
| throw new Error( | ||
| 'Unexpected cross-origin request', |
Owner
There was a problem hiding this comment.
Trying to stay consistent on "authentication response" in error messages:
Suggested change
| 'Unexpected cross-origin request', | |
| 'Unexpected cross-origin authentication response', |
| } | ||
| }); | ||
|
|
||
| Deno.test('should NOT check topOrigin when crossOrigin is false', async () => { |
Owner
There was a problem hiding this comment.
This test is an interesting one. According to the spec, topOrigin should only be set if crossOrigin is true:
It is set only if the call was made from context that is not same-origin with its ancestors, i.e. if crossOrigin is true.
https://w3c.github.io/webauthn/#dom-collectedclientdata-toporigin
Based on this I'd actually make the new code error out if crossOrigin is false but there's a topOrigin defined in clientDataJSON 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support cross-origin authentication on SimpleWebAuthn, this pull request adds the following to the
verifyAuthenticationResponse.ts:expectedTopOriginproperty to theoptionscrossOriginistrueorfalsetopOriginmeets the expectation