run webapp-test onMaster if we're using github actions workflows#386
Open
run webapp-test onMaster if we're using github actions workflows#386
Conversation
…-test job I was trying to test out the new github bridge, passing in all the same parameters buildmaster does but w/ the USE_GITHUB_BRIDGE flag on, and it didn't work, because buildmaster passes a SHA for GIT_REVISION. Which I should have anticipated. Fortunately, buildmaster passes a branch ref as REVISION_DESCRIPTION, so I can use that. Issue: none Test plan: 🤞
… actions workflows no need to spin up a worker just to wait Issue: none Test plan: 🤞 I ran a groovy linter (`pnpx npm-groovy-lint`) and it didn't find anything glaring 🙏
csilvers
approved these changes
May 8, 2026
|
|
||
| def useGithub = params.USE_GITHUB_BRIDGE && params.GIT_TAG; | ||
| if (useGithub) { | ||
| onMaster { |
Member
There was a problem hiding this comment.
Suggested change
| onMaster { | |
| // No need to spin up a worker just to wait on github responding | |
| onMaster { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
no need to spin up a worker just to wait
Issue: none
Test plan:
🤞 I ran a groovy linter (
pnpx npm-groovy-lint) and it didn't find anything glaring 🙏