feat: add FileBrowser app (closes ZimaOS txt/md edit gap)#929
Open
chicohaager wants to merge 4 commits intoIceWhaleTech:mainfrom
Open
feat: add FileBrowser app (closes ZimaOS txt/md edit gap)#929chicohaager wants to merge 4 commits intoIceWhaleTech:mainfrom
chicohaager wants to merge 4 commits intoIceWhaleTech:mainfrom
Conversation
File Browser is a lightweight web file manager with built-in editors for plain text, Markdown, JSON, YAML and source code. The ZimaOS files UI can preview text files but cannot edit them; this app fills that gap as a Docker app pinned to v2.63.3 (s6-overlay variant for PUID/PGID support). filebrowser was already reserved as an ID in featured-apps.json but no Apps/FileBrowser/ entry existed yet — this PR adds it.
- screenshot-1.png: Markdown preview of welcome.md, captured on a live filebrowser deployment running on ZimaOS v1.6.1 (192.168.1.143). Shows the breadcrumb /DATA -> Documents -> notes -> welcome.md, the rendered editor view with save/close/edit toolbar. - tips.before_install: the s6 image variant generates a random initial password instead of the legacy admin/admin. Updated en_us + de_de tips to point users at 'docker logs filebrowser | grep randomly'.
- Remove all de_de strings (description, tagline, tips, env/volume descriptions). The translations were not idiomatic German and reviewer feedback on the PR was to keep this app English-only. en_us and zh_cn remain. - Fix the password-change instruction: it is under 'Settings -> Profile Settings -> Change Password', not 'Settings -> User Management' (the latter is the admin's view of other users). Verified against a live filebrowser instance.
The validator workflow on commit d15607d failed with 'Process completed with exit code 127' after Apps/Resilio-sync — but no specific app emitted a fail. Locally re-running the exact CI loop: find . -type f \( -name docker-compose.yaml -or -name docker-compose.yml \) \ | while read -r f; do casaos-app-management-validator "$f"; done with the same v0.4.16-alpha1 validator binary on all 162 apps in the repo (including this PR's Apps/FileBrowser/docker-compose.yml) returns exit 0 for every file. The earlier two commits on this branch (c411d3c, fe6ad4c) also passed validation — only this third synchronize was hit by what looks like a runner-side flake. Pushing an empty commit to trigger a fresh run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds File Browser (filebrowser/filebrowser) as a CasaOS / ZimaOS app, pinned to
v2.63.3-s6.The ZimaOS Files UI can preview text files (txt, md, conf, yaml, json) but cannot edit them. This app fills that gap with a lightweight web file manager that ships a built-in Monaco-style editor with Markdown live preview, syntax highlighting and inline rename / move / share / archive actions.
filebrowseris already reserved as an ID infeatured-apps.json— but noApps/FileBrowser/entry exists yet. This PR delivers the missing piece.Why this app
vito edit a.mdor a docker.envfile on/DATA. That is friction the average NAS user does not want./DATA-aware: Mounts/DATA -> /srvso the app reaches every file on the NAS. Persistent state lives at/DATA/AppData/$AppID/{database,config}per the AppStore convention.Image / config decisions
v2.63.3-s6(no:latest)-s6variant honoursPUID/PGID, which matches the ZimaOS host user model.${WEBUI_PORT:-8035}WEBUI_PORTis unset.Documentstips.before_installadmin / adminand the volume reaches all of/DATA— a security note before install is mandatory.index: /andport_mapDraft status — what is missing
This PR is intentionally a draft until the
screenshot-1.pngfrom a verified ZimaOS deployment is added. CONTRIBUTING.md is explicit that screenshots must demonstrate the app actually running on CasaOS / ZimaOS, so a stock marketing image would not be appropriate. The screenshot will be added in a follow-up commit on the same branch and the PR marked ready for review at that point.Test plan
docker-compose.ymlis valid YAML and parses withpython3 -m yamlfilebrowser/filebrowser:v2.63.3-s6exists on Docker Hub (multi-arch manifest verified)namematches the required regex^[a-z0-9][a-z0-9_-]*$Apps/FileBrowser/icon.pngNotes for reviewers
IceWhaleTech/AppIcon@main/all/filebrowser.png(560x560 PNG) — same source the IceWhale team has been using for featured branding, so the visual style is consistent.tips.before_installnote explicitly tells users to change the default password — File Browser is a known case where defaults need to be hardened on first login.