Skip to content

Rename the "Table" type to "List" everywhere#4133

Merged
Keavon merged 3 commits intomasterfrom
rename-table-to-list
May 9, 2026
Merged

Rename the "Table" type to "List" everywhere#4133
Keavon merged 3 commits intomasterfrom
rename-table-to-list

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 9, 2026

Part of #3779.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 71 files

Confidence score: 5/5

  • This PR is low risk to merge because the reported items are low-severity maintenance/documentation concerns (2–3/10) rather than functional defects.
  • The most significant issue is terminology inconsistency in editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs (table naming in a List code path), which mainly affects readability and future maintenance clarity.
  • A stale doc-comment type name in node-graph/libraries/core-types/src/ops.rs (AttributeColumnDyn vs AttributeDyn) could mislead readers of generated docs but should not affect runtime behavior.
  • Pay close attention to editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs and node-graph/libraries/core-types/src/ops.rs - naming/doc accuracy should be cleaned up to reduce developer confusion.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs">

<violation number="1" location="editor/src/messages/portfolio/document/data_panel/data_panel_message_handler.rs:1009">
P3: Rename remaining `table`-named identifiers in this `List` code path to keep terminology consistent and avoid confusion during maintenance.

(Based on your team's feedback about consistent, precise terminology in names and docs.) [FEEDBACK_USED]</violation>
</file>

<file name="node-graph/libraries/core-types/src/ops.rs">

<violation number="1" location="node-graph/libraries/core-types/src/ops.rs:76">
P3: The doc comment references `AttributeColumnDyn`, but the actual type here is `AttributeDyn`. This stale name is misleading when reading generated docs.

(Based on your team's feedback about consistent, precise terminology in names and docs.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread node-graph/libraries/core-types/src/ops.rs Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive rename of the Table data structure to List throughout the codebase, including type definitions, trait implementations, function names, and documentation comments. This change aims to improve naming consistency and clarity within the node graph engine. The review comments suggest further renaming TableItemLayout to ListItemLayout and table_node_id_path_layout_with_breadcrumb to list_node_id_path_layout_with_breadcrumb to maintain full consistency with the new terminology.

@Keavon Keavon merged commit a28b943 into master May 9, 2026
12 checks passed
@Keavon Keavon deleted the rename-table-to-list branch May 9, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant