Remove -b flag for C# parser#846
Remove -b flag for C# parser#846LakatosMark1 wants to merge 2 commits intoEricsson:feature/csharp_pluginfrom
Conversation
…roj and populate build graph
mcserep
added
Plugin: C#
| void addSource(const std::string& filepath_, bool error_); | ||
| const std::vector<std::string>& path_ //, | ||
| ); //const std::string& buildPath_ | ||
| //void addSource(const std::string& filepath_, bool error_); |
There was a problem hiding this comment.
Remove commented out code from codebase.
| bool CsharpParser::parseProjectBuildPath( | ||
| const std::vector<std::string>& paths_, | ||
| const std::string& buildPath_) | ||
| const std::vector<std::string>& paths_ //, |
There was a problem hiding this comment.
Remove commented out comma.
There was a problem hiding this comment.
@LakatosMark1 This is still a pending formatting issue.
|
I have made the canges requested! |
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Looks almost ready now, some final touches and questions remain.
| { | ||
| if (line[0] == '+' || line[0] == '-') | ||
| // Skip empty lines or non-JSON lines (like debug info "ParallelRun ...") | ||
| if (line.empty() || line[0] != '{') continue; |
There was a problem hiding this comment.
I don't really get this, in a valid JSON file / content, not every line starts with a { char neccesearily.
There was a problem hiding this comment.
Since it's pretty much impossible to reliably determine if a line is valid JSON on the C++ side, I was thinking about a different approach. What if we redirect all non-JSON messages (like logs and debug info) to Console.Error.WriteLine in the C# parser? This way, stdout will strictly contain the JSON payload, and we can completely remove the line filtering logic here. What do you think about this approach?
| visitor.Visit(tree.GetCompilationUnitRoot()); | ||
|
|
||
| // Find the DLL name and append a | to the filename. | ||
| string target = fileToTargetDll.ContainsKey(tree.FilePath) ? fileToTargetDll[tree.FilePath] : "Unknown.dll"; |
There was a problem hiding this comment.
As discussed on previous meeting, we shall not use a fake "Unknown.dll" filename. That could be a valid file. Use null or maybe empty string as extremal value.
2 participants
Refactor C# parser to extract target DLLs from .csproj and populate build graph
Resolves #820