Skip to content

Remove deprecated internal spanBuilder methods#11287

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
andrea.marziali/deprecate
May 11, 2026
Merged

Remove deprecated internal spanBuilder methods#11287
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
andrea.marziali/deprecate

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented May 6, 2026

What Does This Do

Follows up #11181 by finishing cleaning up deprecated signature for buildSpan and buildSingleSpan that were not carrying instrumentation name.

Note: usages are mostly in tests for this ones

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali amarziali added type: enhancement Enhancements and improvements comp: core Tracer core labels May 6, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 6, 2026

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1778505954 1778506301
end_time 2026-05-11T13:27:21 2026-05-11T13:33:07
git_branch master andrea.marziali/deprecate
git_commit_sha 10e03bd 6a4f349
start_time 2026-05-11T13:25:55 2026-05-11T13:31:42
See matching parameters
Baseline Candidate
ci_job_id 1671981029 1671981029
ci_pipeline_id 112464948 112464948
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1778504967 1778504967

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-36.290µs; +12.201µs] or [-12.081%; +4.062%]
unstable
[-49.805µs; +17.678µs] or [-14.370%; +5.100%]
unstable
[-64.368µs; +25.167µs] or [-17.654%; +6.902%]
unstable
[-11.340µs; +200.786µs] or [-0.911%; +16.138%]
same
scenario:basic same same same unstable
[+198.386µs; +478.712µs] or [+19.629%; +47.366%]
same
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (346.589 µs) : 308, 385
.   : milestone, 347,
basic (296.129 µs) : 289, 303
.   : milestone, 296,
loop (8.973 ms) : 8967, 8979
.   : milestone, 8973,
section candidate
noprobe (330.525 µs) : 307, 354
.   : milestone, 331,
basic (295.257 µs) : 289, 302
.   : milestone, 295,
loop (8.973 ms) : 8968, 8978
.   : milestone, 8973,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 346.589 µs [307.719 µs, 385.459 µs]
basic 296.129 µs [289.408 µs, 302.85 µs]
loop 8.973 ms [8.967 ms, 8.979 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 330.525 µs [307.161 µs, 353.89 µs]
basic 295.257 µs [288.685 µs, 301.83 µs]
loop 8.973 ms [8.968 ms, 8.978 ms]

@amarziali amarziali force-pushed the andrea.marziali/deprecate branch from c595015 to 0eab488 Compare May 7, 2026 12:15
@amarziali amarziali marked this pull request as ready for review May 11, 2026 06:57
@amarziali amarziali requested review from a team as code owners May 11, 2026 06:57
@amarziali amarziali requested review from andreimatei, claponcet, jandro996 and mcculls and removed request for a team May 11, 2026 06:57
Copy link
Copy Markdown
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the debugger spans are renamed to dynamic-instrumentation - thanks!

@amarziali amarziali force-pushed the andrea.marziali/deprecate branch from 05d8b41 to 6a4f349 Compare May 11, 2026 13:09
@amarziali amarziali enabled auto-merge May 11, 2026 13:09
@amarziali amarziali added this pull request to the merge queue May 11, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 11, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 11, 2026

View all feedbacks in Devflow UI.

2026-05-11 14:09:50 UTC ℹ️ Start processing command /merge


2026-05-11 14:09:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-11 15:39:11 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 11, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 74cb793 into master May 11, 2026
578 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/deprecate branch May 11, 2026 15:39
@github-actions github-actions Bot added this to the 1.63.0 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants