Remove deprecated internal spanBuilder methods#11287
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoMay 11, 2026
Merged
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (346.589 µs) : 308, 385
. : milestone, 347,
basic (296.129 µs) : 289, 303
. : milestone, 296,
loop (8.973 ms) : 8967, 8979
. : milestone, 8973,
section candidate
noprobe (330.525 µs) : 307, 354
. : milestone, 331,
basic (295.257 µs) : 289, 302
. : milestone, 295,
loop (8.973 ms) : 8968, 8978
. : milestone, 8973,
|
c595015 to
0eab488
Compare
amarziali
commented
May 11, 2026
mcculls
approved these changes
May 11, 2026
Contributor
mcculls
left a comment
There was a problem hiding this comment.
LGTM once the debugger spans are renamed to dynamic-instrumentation - thanks!
05d8b41 to
6a4f349
Compare
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
bric3
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Follows up #11181 by finishing cleaning up deprecated signature for
buildSpanandbuildSingleSpanthat were not carrying instrumentation name.Note: usages are mostly in tests for this ones
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.