Add core C++ support for otioz and otiod, take 2#2021
Draft
darbyjohnston wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
Draft
Add core C++ support for otioz and otiod, take 2#2021darbyjohnston wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
darbyjohnston wants to merge 9 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov Report❌ Patch coverage is ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
- Coverage 84.50% 83.34% -1.17%
==========================================
Files 181 180 -1
Lines 13225 13317 +92
Branches 1202 1218 +16
==========================================
- Hits 11176 11099 -77
- Misses 1866 2046 +180
+ Partials 183 172 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1869
This PR adds support for otioz and otiod bundles to the C++ API. This PR is a second attempt at adding the functionality, superseding PR #1901.
The python otioz and otioz adapters still exist and work the same, but now they call into the C++ code for the bundle functionality.
Support for image sequences and multiple media references has been added.
Other changes:
depsdirectory to simplify the build process (as opposed to building it as a library from a submodule).Questions:
Assisted-by: Claude:claude-opus-4-7 [code-review] [debugging]