Description
The Glide block is intended to create a glissando effect by blending overlapping successive notes. However, it currently does not apply a true pitch glide (portamento) through the synthesizer.
As noted in a TODO inside js/blocks/OrnamentBlocks.js (inside the GlideBlock class):
"Duration should be the sum of all the notes (like in a tie). If we set the synth portamento and use setNote for all but the first note, it should produce a glissando."
Expected Behavior
- The duration of the glide should be correctly calculated as the sum of all notes enclosed.
- The synthesizer should utilize Tone.js'
portamento property (or setNote for subsequent notes) to create a continuous, sliding pitch effect between the notes rather than discrete steps.
Screenshot
Multiple note blocks (with distinct pitches) placed inside the mouth of the glide block.
No duration argument attached to the top of the glide block (which means it defaulted to a 1/16th of a beat transition time).
How to Reproduce
- Open MusicBlocks.
- Create a sequence of notes with different pitches.
- Wrap them in a
Glide block.
- Play the sequence. Notice that the notes play individually rather than sliding smoothly from one pitch to the next.
Environment:
- Version: master branch
- File:
js/blocks/OrnamentBlocks.js
I would like to work on this issue and submit a PR for it!
Description
The
Glideblock is intended to create a glissando effect by blending overlapping successive notes. However, it currently does not apply a true pitch glide (portamento) through the synthesizer.As noted in a
TODOinsidejs/blocks/OrnamentBlocks.js(inside theGlideBlockclass):Expected Behavior
portamentoproperty (orsetNotefor subsequent notes) to create a continuous, sliding pitch effect between the notes rather than discrete steps.Screenshot
How to Reproduce
Glideblock.Environment:
js/blocks/OrnamentBlocks.jsI would like to work on this issue and submit a PR for it!